WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#13389 closed defect (bug) (fixed)

Close #wrap before including admin-footer.php

Reported by: Caspie Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: Administration Keywords: admin-footer
Focuses: Cc:

Description

In network.php (Network Step 1 on error/warrning) - The #wrap div should be closed to keep the sticky footer to the bottom.

Attachments (1)

network.php.diff (1.6 KB) - added by Caspie 5 years ago.
small patch

Download all attachments as: .zip

Change History (5)

@Caspie5 years ago

small patch

comment:1 follow-up: @nacin5 years ago

Thanks for the patch.

For future reference, we use tabs.

comment:2 @nacin5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [14630]) Close wrapper div when ending network_step1 with a warning. props Caspie, fixes #13389.

comment:3 in reply to: ↑ 1 @Caspie5 years ago

Replying to nacin:

Thanks for the patch.

For future reference, we use tabs.

That was my first one :) Sorry about the tabs, my editor was set to convert tab to 4 spaces. Noticed that too late, hehe :>

comment:4 @nacin5 years ago

No problem! Congratulations on your first patch.

Note: See TracTickets for help on using tickets.