"Show on screen" in screen options shown twice on some screens

[azaozz]

Introduced in [14287]. I know the whole screen_meta() function is a bit messy but lately it seems it's getting messier instead of being streamlined. Generally each different type of settings there is handled by a separate function in wp-admin/includes/template.php and different JS. That avoids conflicts and makes future development easier.

[azaozz]

[14287] also adds couple of very marginal hooks on the "Show on screen" string that IMHO are useless. Why would a plugin want to change a consistent, UX checked, translated string to an (mostly) untranslated, inconsistent one?

Each hook adds a bit of processing time and more importantly each hook is a big "STOP" sign in future development. Once introduced it cannot be changed or all plugins using it would break. This adds complexity, possibility of introducing bugs and more backwards compatibility checking so new hooks should be added "sensibly".

[duck_]

Fixes the unwanted appearance of an extra "Show on screen", doesn't streamline the function as azaozz is suggesting.

[westi]

Looking into this now.

Agree with azaozz those filters look suspect

[westi]

(In [14635]) Only show the column preferences if we have columns. See #13393 props duck_.

[westi]

(In [14636]) Remove unnecessary filters and provide for translation context instead. Fixes #13393.

[westi]

(In [14637]) Try and tidy up the show_screen logic a little.
Implement a better override of the column header.
See #13393.

[westi]

(In [14638]) Try and tidy up the show_screen logic a little.
Implement a better override of the column header.
See #13393.

[westi]

[14768]