WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#13393 closed defect (bug) (fixed)

"Show on screen" in screen options shown twice on some screens

Reported by: azaozz Owned by:
Milestone: 3.0 Priority: high
Severity: normal Version: 3.0
Component: Menus Keywords: needs-patch
Focuses: Cc:

Description

Introduced in [14287]. I know the whole screen_meta() function is a bit messy but lately it seems it's getting messier instead of being streamlined. Generally each different type of settings there is handled by a separate function in wp-admin/includes/template.php and different JS. That avoids conflicts and makes future development easier.

Attachments (1)

13393.diff (519 bytes) - added by duck_ 4 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 azaozz4 years ago

[14287] also adds couple of very marginal hooks on the "Show on screen" string that IMHO are useless. Why would a plugin want to change a consistent, UX checked, translated string to an (mostly) untranslated, inconsistent one?

Each hook adds a bit of processing time and more importantly each hook is a big "STOP" sign in future development. Once introduced it cannot be changed or all plugins using it would break. This adds complexity, possibility of introducing bugs and more backwards compatibility checking so new hooks should be added "sensibly".

duck_4 years ago

comment:2 duck_4 years ago

Fixes the unwanted appearance of an extra "Show on screen", doesn't streamline the function as azaozz is suggesting.

comment:3 westi4 years ago

Looking into this now.

Agree with azaozz those filters look suspect

comment:4 westi4 years ago

(In [14635]) Only show the column preferences if we have columns. See #13393 props duck_.

comment:5 westi4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [14636]) Remove unnecessary filters and provide for translation context instead. Fixes #13393.

comment:6 westi4 years ago

(In [14637]) Try and tidy up the show_screen logic a little.
Implement a better override of the column header.
See #13393.

comment:7 westi4 years ago

(In [14638]) Try and tidy up the show_screen logic a little.
Implement a better override of the column header.
See #13393.

Note: See TracTickets for help on using tickets.