WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#13400 closed defect (bug) (fixed)

Autosave too slow to re-enable publishing buttons

Reported by: duck_ Owned by: azaozz
Milestone: 3.0 Priority: normal
Severity: blocker Version: 3.0
Component: Autosave Keywords: has-patch needs-testing
Focuses: Cc:

Description

The autosave_update_post_ID function in autosave.js is pretty much useless since r12987 because it will always return early due to new posts now having an ID (line 147). Side effects being that the publishing buttons take the default 5 seconds to be enabled again and the post continues to be recognised as an auto-draft (so this will happen on further autosaves). This could be especially annoying on custom post types which only have a title, enter the title click out of the box (but not publish etc.) you now have to wait 5 seconds before publishing.

Also, the trash button is always shown and the hiddenaction is always 'editpost', so no need to fadeIn and change value respectively.

The only other place the autosave_update_post_ID function is used is in response to adding a custom field (post.js), again, in its current form this is useless.

Attachments (1)

autosave-new.diff (1.9 KB) - added by duck_ 4 years ago.

Download all attachments as: .zip

Change History (5)

duck_4 years ago

comment:1 duck_4 years ago

  • Component changed from General to Autosave
  • Owner set to azaozz

comment:2 nacin4 years ago

  • Milestone changed from Unassigned to 3.0

comment:3 ryan4 years ago

  • Severity changed from normal to blocker

comment:4 ryan4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [14663]) autosave_update_post_ID() no longer needed. Fix button enable lag. Props duck_. fixes #13400

Note: See TracTickets for help on using tickets.