WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#13403 closed defect (bug) (fixed)

edit.php should check for show_ui, not public

Reported by: nacin Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Posts, Post Types Keywords: 2nd-opinion
Focuses: Cc:

Description

If you give a post type show_ui = true, but don't set public, you can't get into edit.php?post_type=mytype, even though it shows it in the admin UI.

Catch is, show_ui is false for posts and pages. We'd have to account for them manually.

Maybe show_ui should be true for posts and pages, and then account for them manually in menu.php instead.

Change History (4)

comment:1 @nacin5 years ago

  • Component changed from General to Post Types

comment:2 @nacin5 years ago

(In [14674]) Use show_ui instead of public flag to check whether the post type uses post-new and edit.php. see #13403.

comment:3 @nacin5 years ago

Leaving open for decision on whether show_ui should be true for posts and pages. I'd say they absolutely should be -- otherwise they're still "special" post types even though they are pretty much severed in every way except for the menu. (Unlike categories and tags, which are still treated as quite special by core.)

comment:4 @ryan5 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.