Querying Taxonomies (Tag) containing the sequence "-נ-" fails.

[hakre]

Fresh from Beta testing latest trunk:

1.) Created a Tag "test -נ- end"

2.) Added the Tag to a Post

3.) Pressed that Tag in my Tag Cloud

4.) Get the not Found Message.

[nacin]

Is this not an obvious duplicate of #11669?

[hakre]

This went through, related tickets were:

#11669, #11724

#11669 is not a duplicate because that is 2.9 and cutting names. The tag now works while creating it. This time it is about querying all pages with that tag I guess. I dunno where that 404 actually comes from. That needs to be investigated further.

#11724 might be the exact same thing, but I'm not sure.

[dd32]

Is this a regression from 2.9?

[ryan]

I cut-and-paste that text and couldn't reproduce in 2.9 or 3.0, for what it's worth.

[ocean90]

I could reproduce it in 3.0 and 2.9 on my local install (windows, xampp) but not on my server install.

[ryan]

If it's not a regression in 3.0 then let's move it to 3.1. There are similar tickets we can take care of at the same time.

[hakre]

Replying to ocean90:

I could reproduce it in 3.0 and 2.9 on my local install (windows, xampp) but not on my server install.

Good you wrote that, my report is based on windows as well.

[hakre]

Related: #14292

[hakre]

Related: #14313

[hakre]

I was able to fix the problem with the patch. The cause is that the regex used does not properly handle UTF-8 encoded strings. The \s character class is causing this again (see [12501]). Will scan core for more of these.

[hakre]

Scan finished, core has more places where \s is used on UTF-8 strings.

[hakre]

Minified Patch

[hakre]

I reduced the code changes to the bare minimum. The first patch contains some code cleanups and on function did return a reference which was not necessary because the return value was an array.

[wojtek.szkutnik]

I think you missed one ;)

[hakre]

Right, my patch did not focus on author. Had you run a test for authors?

[hakre]

Still looks good for 3.1 in my eyes.

[westi]

Tested in trunk and this works fine for me.

[hakre]

Could not reproduce with trunk any longer:

Worked with PHP 5.2.14 (cli) (built: Jul 27 2010 10:43:58) on win 32.

Tried to get PHP 4 running to check if it's related to an older version (I remember it's a windows specific bug and I smell/assume this is related to some pcre lib version) but was not able to get PHP 4 running any longer and didn't want to downgrade PHP 5.2.

X-Ref: #16765

[SergeyBiryukov]

Follow-up: #21779

[nacin]

In [21862]:

Split tag names by [\r\n\t ] rather than \s to avoid that character class from eating characters. props rstern, SergeyBiryukov. fixes #21779. see #13413.