Opened 14 years ago
Closed 11 years ago
#13416 closed defect (bug) (wontfix)
media for install.css missing (patch)
Reported by: | F J Kaiser | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 3.0 |
Component: | Administration | Keywords: | has-patch |
Focuses: | ui | Cc: |
Description
In /core-root/wp-includes/general_template.php the function wp_admin_css is missing the @media definition. See patch.
Attachments (2)
Change History (12)
#4
@
14 years ago
I like the idea, patch still applies clean.
If there can be made no decision whether or not to use that (no idea if the rest of WP uses that attribute) I suggest to close the ticket as wontfix.
#5
@
14 years ago
Just leave it open until there is a decision based on a discussion. No need for getting rid of this just to make the list shorter.
#7
follow-up:
↓ 8
@
12 years ago
- Component changed from UI to Administration
- Keywords ui-focus added
- Milestone changed from Future Release to Awaiting Review
Refreshed the patch on current trunk. I'd vote to keep it screen
in the patch if only because we can't guarantee all
. OTOH, the script-loader uses all
.
#8
in reply to:
↑ 7
@
12 years ago
Replying to DrewAPicture:
Refreshed the patch on current trunk.
Remind me next time to update an open tab before making a patch :P
Moving out of 3.0 for now. The media attribute isn't required, and if omitted, it defaults to 'all'. So setting it to 'screen' might affect some other views and devices.