WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 2 months ago

#13416 closed defect (bug) (wontfix)

media for install.css missing (patch)

Reported by: F J Kaiser Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.0
Component: Administration Keywords: has-patch
Focuses: ui Cc:

Description

In /core-root/wp-includes/general_template.php the function wp_admin_css is missing the @media definition. See patch.

Attachments (2)

general_template-install-css.patch (926 bytes) - added by F J Kaiser 4 years ago.
13416.diff (952 bytes) - added by DrewAPicture 15 months ago.

Download all attachments as: .zip

Change History (12)

comment:1 F J Kaiser4 years ago

  • Cc 24-7@… added

comment:2 F J Kaiser4 years ago

  • Keywords has-patch added

comment:3 nacin4 years ago

  • Milestone changed from 3.0 to Future Release

Moving out of 3.0 for now. The media attribute isn't required, and if omitted, it defaults to 'all'. So setting it to 'screen' might affect some other views and devices.

comment:4 hakre4 years ago

I like the idea, patch still applies clean.

If there can be made no decision whether or not to use that (no idea if the rest of WP uses that attribute) I suggest to close the ticket as wontfix.

comment:5 F J Kaiser4 years ago

Just leave it open until there is a decision based on a discussion. No need for getting rid of this just to make the list shorter.

comment:6 SergeyBiryukov20 months ago

  • Component changed from General to UI
  • Keywords css install media removed

DrewAPicture15 months ago

comment:7 follow-up: DrewAPicture15 months ago

  • Component changed from UI to Administration
  • Keywords ui-focus added
  • Milestone changed from Future Release to Awaiting Review

Refreshed the patch on current trunk. I'd vote to keep it screen in the patch if only because we can't guarantee all. OTOH, the script-loader uses all.

comment:8 in reply to: ↑ 7 F J Kaiser15 months ago

Replying to DrewAPicture:

Refreshed the patch on current trunk.

Remind me next time to update an open tab before making a patch :P

comment:9 mdawaffe9 months ago

What is the benefit of adding media="screen"? The rest of core uses media="all" (at least by default).

comment:10 nacin2 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.