WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #13429, comment 44


Ignore:
Timestamp:
03/09/12 22:08:36 (2 years ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #13429, comment 44

    initial v1  
    33Did some quick testing and don't see any problems with attachment links and URLs to attached files that would require them to be fixed/rewritten after the post is saved. Seems we can safely stop replacing the URLs. 
    44 
    5 There is also another part to `_fix_attachment_links()`. It attaches orphaned attachments when they are used in a post (if the "wp-att-###" bit is present). This is useful for files that were uploaded directly from the Media -> Library screen. However we are also doing something similar while inserting a file into the editor (in media.php), so not sure if repeating it is needed. 
     5There is also another part to `_fix_attachment_links()`. It attaches orphaned attachments when they are used in a post (if the "wp-att-###" bit is present). This is useful for files that were uploaded directly from the Media -> Add New screen. However we are also doing something similar while inserting a file into the editor (in media.php), so not sure if repeating it is needed. 
    66 
    77Overall removing `_fix_attachment_links()` seems the proper solution. This also improves performance while saving a post.