Make WordPress Core

Opened 14 years ago

Closed 13 years ago

#13440 closed task (blessed) (fixed)

rss_language option should be blog language

Reported by: lazy79's profile Lazy79 Owned by: nacin's profile nacin
Milestone: 3.4 Priority: low
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

the rss_language option in the database should automaticaly be updated to en (std.) or the language in wp-config.php

i know its not a important deal but there a situations where it might be good to have rss_language the language slug which the blog uses.

Attachments (1)

13440.diff (7.7 KB) - added by nacin 13 years ago.

Download all attachments as: .zip

Change History (8)

#1 @westi
14 years ago

  • Milestone changed from 3.0 to Future Release

rss_language is set to en by default upon install.

If you want to change it then all the API is there to do it and you could use the pre_option_ filters in get_option in a plugin to return the value configured in wp-config.php if you want.

I don't think we need to do anything in core for 3.0 for this as it has been like this for a long time.

#2 @dd32
14 years ago

See also: #5517 and #6854

#3 @nacin
13 years ago

  • Keywords rss_language removed
  • Milestone changed from Future Release to 3.4
  • Type changed from feature request to task (blessed)

Accepting this for inclusion.

I am thinking we just kill off rss_language and have it use get_bloginfo( 'language' ) which in turns relies on get_locale(). This is exactly the value that language_attributes() uses.

#4 @nacin
13 years ago

  • Component changed from General to I18N
  • Keywords has-patch added

@nacin
13 years ago

#5 @ramiy
13 years ago

  • Cc r_a_m_i@… added

#6 @ryan
13 years ago

Using the same thing language_attributes( ) uses seems sanest. Patch looks good.

#7 @nacin
13 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [19784]:

Use the site's locale for the feed language. Provides the same result as language_attributes(). Removes the rss_language option. fixes #13440. see #5517.

Note: See TracTickets for help on using tickets.