Make WordPress Core

Opened 14 years ago

Closed 14 years ago

#13444 closed defect (bug) (fixed)

Need to reflect correct post_type references

Reported by: michaelh's profile michaelh Owned by: nbachiyski's profile nbachiyski
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

Where it currently displays post or page, it should use the correct post_type instead.

If the post_type is Book:

  1. In the Edit screen when you hover over Edit it should say "Edit this book" and so on...
  1. When a Book is saved/updated it should say "Book updated. View book" and so on...

Attachments (2)

13444_1.diff (6.0 KB) - added by michaelh 14 years ago.
correct strings for post_type in wp-admin/includes/template.php
13444_2.diff (4.4 KB) - added by michaelh 14 years ago.
correct strings for post_type in wp-admin/edit-form-advanced.php

Download all attachments as: .zip

Change History (7)

@michaelh
14 years ago

correct strings for post_type in wp-admin/includes/template.php

#1 @nacin
14 years ago

We have no plans to introduce "Labels" more than we already have, because the rest are at the whims of core UX/UI. So, we'd have to offer a filter for the giant $messages array in edit-form-advanced.php. I was just trying to come up with a better way to do it, but I think that'll have to do. We'll have to be mindful of not changing the meaning of one of those strings in the future.

@michaelh
14 years ago

correct strings for post_type in wp-admin/edit-form-advanced.php

#2 @michaelh
14 years ago

  • Component changed from General to i18n
  • Owner set to nbachiyski

Okay understood--especially after changing that $messages array. Will leave this for you to punt or close as appropriate.

#3 @ryan
14 years ago

  • Milestone 3.0 deleted
  • Resolution set to fixed
  • Status changed from new to closed

Let's close for now. Someday we'll figure out how best to handle this. We might change to more generic strings, as we have already done in a few places.

#4 @nacin
14 years ago

  • Milestone set to 3.0
  • Resolution fixed deleted
  • Status changed from closed to reopened

Going to add a filter to $messages.

#5 @nacin
14 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [14801]) Add post_updated_messages filter. Include explicit indexes in the arrays to make it easier for plugin authors to follow. fixes #13444.

Note: See TracTickets for help on using tickets.