WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#13474 closed task (blessed) (fixed)

Revise update notification bubble colour

Reported by: johnonolan Owned by: nacin
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: UI Keywords: ux-feedback has-patch
Focuses: Cc:

Description

Move from the WordPress 2.5 orange (d54e21) to a new one put forward by the UI group (ee7600) - http://twitpic.com/1meikk/full .

This was originally just for the background of the update notification bubble however due to the way it was coded it was a lot easier to blanket implement it so that link hover states are bundled in!

Attachments (3)

13474.diff (2.0 KB) - added by johnonolan 10 years ago.
13474.2.diff (1.9 KB) - added by johnonolan 10 years ago.
New patch for grey bubbles
13474.3.diff (2.1 KB) - added by johnonolan 10 years ago.
Revised patch without hover state

Download all attachments as: .zip

Change History (26)

@johnonolan
10 years ago

#2 follow-up: @nacin
10 years ago

We use this orange in blue/classic as well, as well as a few other spots:

./wp-admin/css/colors-classic.dev.css:232:	color: #d54e21;
./wp-admin/css/colors-classic.dev.css:268:	background-color: #d54e21;
./wp-admin/css/colors-classic.dev.css:361:	color: #d54e21;
./wp-admin/css/colors-classic.dev.css:377:	color: #d54e21;
./wp-admin/css/colors-classic.dev.css:434:	color: #d54e21;
./wp-admin/css/colors-classic.dev.css:501:	color: #d54e21;
./wp-admin/css/colors-classic.dev.css:509:	background-color: #d54e21;
./wp-admin/css/colors-classic.dev.css:579:	color: #d54e21 !important;
./wp-admin/css/colors-classic.dev.css:1289:	color: #d54e21;
./wp-admin/css/colors-classic.dev.css:1395:	color: #d54e21;
./wp-admin/css/colors-classic.dev.css:1416:	color: #d54e21;
./wp-admin/css/colors-classic.dev.css:1669:	color: #d54e21;
./wp-admin/css/dashboard.dev.css:148:	color: #d54e21;
./wp-admin/css/install.dev.css:25:	color: #d54e21;
./wp-includes/js/tinymce/wp-mce-help.php:47:		color: #d54e21;
./wp-includes/js/tinymce/wp-mce-help.php:58:		color: #d54e21;

Are we ready to move to this orange for links as well? Just confirming. It's arguably a little light.

#3 in reply to: ↑ 2 @Denis-de-Bernardy
10 years ago

Replying to nacin:

It's arguably a little light.

+1. My eyes are hurting.

#4 @ocean90
10 years ago

-10 for #ee7600.

#5 @johnonolan
10 years ago

I'm on the fence with this one, I can see both sides. Let's see what Jane says and go from there!

#6 @jane
10 years ago

I like it better than the burnt orange for the # bubble, but don't like it for the text b/c it's a bit too light. However, since we're still potentially going to adjust the on-state background color, maybe this one should wait for that, as the orange may or may not be relevant at that point.

#7 @nacin
10 years ago

Move out of 3.0 then?

#8 @jane
10 years ago

We're shooting to get it done before RC. No ticket to link to yet, though. John's working on it with a new contributor.

#9 @johnonolan
10 years ago

  • Priority changed from high to normal

As a followup to Jane's comment this ticket is dependent on #13486 being completed first

#11 @jane
10 years ago

I think we're going with gray instead of blue after all, and moving to a dark gray bubble instead of orange goes along with that.

#12 @johnonolan
10 years ago

+1, I'll work on that next

@johnonolan
10 years ago

New patch for grey bubbles

#13 @johnonolan
10 years ago

  • Summary changed from Move To New Orange to Revise update notification bubble colour

Screenshot of all states http://drp.ly/14lHeA

#14 @jane
10 years ago

The blue bubble on hover seems a little weird... I think it might look better either do orange, so all hover is the same in the menu and it matches the adjacent text, or to leave it gray, so it doesn't look like the bubble is an independent link.

@johnonolan
10 years ago

Revised patch without hover state

#15 follow-up: @Denis-de-Bernardy
10 years ago

what's wrong with the current color?

#16 in reply to: ↑ 15 @nacin
10 years ago

Replying to Denis-de-Bernardy:

what's wrong with the current color?

It's from the 2.5 design, doesn't fit with the rest of the admin because of that, and needs a new coat of paint.

#17 @johnonolan
10 years ago

Jane - what about the hover-state of the comment-count bubble in the "in response to" column of the comment moderation screen? Currently goes blue > orange - do you want to go blue > grey?

#18 @jane
10 years ago

That one can stay orange since it is actually a link, and if it was going to change, it would be on a different ticket, since it's not update related. One's a notification and one's a graphical link, so the bubble on comments should act like the links.

#19 @nacin
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [14918]) New admin menu notification bubble color. props JohnONolan, fixes #13474.

#20 follow-up: @Viper007Bond
10 years ago

For what it's worth, I'm not a fan. It sticks out like a sore thumb.

#21 in reply to: ↑ 20 @nacin
10 years ago

Replying to Viper007Bond:

For what it's worth, I'm not a fan. It sticks out like a sore thumb.

Pretty sure that's the idea ;)

#22 @nacin
10 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

This changed the color of the "Install Update Now" button (or other related text) for the plugin thickbox. Probably need to switch classes.

#23 @nacin
10 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

[14980]

Use orange for the plugin install thickbox button, not the new gray for update notification bubbles. fixes #13474.

Note: See TracTickets for help on using tickets.