WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#13479 closed defect (bug) (fixed)

Multisite over-quota message fine-tuning

Reported by: dd32 Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: Upload Keywords: ux-feedback has-patch
Focuses: Cc:

Description

Currently if you visit Media -> Add New whilst over-quota on Multisite, you're greeted by the following string:

Sorry, you must delete files before you can upload any more.

IMO, This could be worded better (Thanks to JohnONolan for some input here), such as:

Sorry, you have filled your maximum upload quota (...MB). To upload more items, please delete some files to make room.

Thoughts on some better wording for this?

(Ref: wp-admin/includes/media.php L#1437)

Attachments (3)

media.diff (512 bytes) - added by tmoorewp 4 years ago.
ms-options.diff (2.4 KB) - added by tmoorewp 4 years ago.
schema.diff (659 bytes) - added by tmoorewp 4 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 johnonolan4 years ago

  • Keywords ux-feedback added; ui-feedback removed

+1

comment:2 nacin4 years ago

  • Keywords needs-patch added

tmoorewp4 years ago

tmoorewp4 years ago

tmoorewp4 years ago

comment:3 tmoorewp4 years ago

  • Cc tim.moore@… added
  • Keywords has-patch added; needs-patch removed

I've attached a patch. It allows Super Admins to customize the message and sets a default. This could be useful, in my opinion, if you run different types of networks (like mine is a university network; I'd rather tell people to contact a certain person and request more space than to just delete files).

comment:4 ryan4 years ago

No message customization please. That's what filters and gettext are for. Variables cannot be passed to __().

comment:5 nacin4 years ago

Current suggestion, with no suggestion on what to do to decrease space: "Sorry, you have filled your storage quota ($amt MB)."

Surely people know that a quota means they need to delete if that's what they want to do. I don't like suggesting they delete files.

comment:6 markjaquith4 years ago

They also have the option of asking the site admin to increase their limit. I like:

"Sorry, you have filled your storage quota ($amt MB)."

comment:7 automattor4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [14897]) Update upload quota filled message to mention the limit and not suggest file deletion. fixes #13479

Note: See TracTickets for help on using tickets.