html entities in pluggable text/plain mail notifications

[arena]

Reminder : in wp_mail

• The default content type is 'text/plain' which does not allow using HTML.

in 2.9 we had

$notify_message  = sprintf( __('New comment on your post #%1$s "%2$s"'), $comment->comment_post_ID, $post->post_title ) . "\r\n";

in 3.0 we have

$notify_message  = sprintf( __( 'New comment on your post “%s”' ), $post->post_title ) . "\r\n";

All mails needs a review !

[nacin]

Went in [14070], I presume.

[arena]

extract of some (not all) differences

[ryan]

(In [14803]) Email messages should be plain text. Props arena. see #13488

[westi]

Reviewed:

• wp_notify_moderator
• wp_notify_postauthor
• wp_new_user_notification
• wp_password_change_notification
• newblog_notify_siteadmin
• newuser_notify_siteadmin
• wpmu_signup_blog_notification
• wpmu_signup_user_notification
• wpmu_welcome_notification
• wpmu_welcome_user_notification

All look ok.

Closing as Fixed.

[demetris]

The HTML entities in those messages were my mistake. My apologies!

A question:

What would happen if we started using UTF-8 in such messages? Like:

sprintf(__('New comment on your post “%s”'), $post->post_title)

Would there be problems with any modern clients? (I know that the two clients I use, Thunderbird and Gmail, work fine with UTF-8.)

[chriscct7]

#10005 was marked as a duplicate.