Ajax deletion of media broken due to Trashing remains

[dd32]

To reproduce:

1. Upload a file
2. Expand to view file details
3. Click Delete, Follow through.

Result: Page reloads and deletes the object

Expected Result: At some point here, Ajax deletion is supposed to kick in.

prepareMediaItemInit() in swfupload handlers.dev.js contains some Ajax trash/undo code, which is never hit, It looks like it was never removed when the Media trashing code was striped out.

[dd32]

Media trashing was removed in 2.9, or at least, the UI for it was. The backend code has been left in place for when it was to be fully integrated, hopefully with 3.0. That hasnt happened however.

Given that this was broken in 2.9 i would assume now, This probably isnt that high of a priority for 3.0, If someone can provide a patch, go for it.

[ocean90]

• added trashSuccess and trashError
• revert old deleteSuccess and deleteError
• fix nonce bug

No it works with MEDIA_TRASH and without.

[ryan]

Not a regression so moving to 3.1. Need to get review from azaozz since he knows the full history here.

[ocean90]

Updated patch and closed #13846 as dup, because it's fixed with this patch.

[ocean90]

I will create a new patch so azaozz can review it.

[ocean90]

My first patch on a Mac :)

[ocean90]

The patch works with define('MEDIA_TRASH', true);, define('EMPTY_TRASH_DAYS', 0); and without too.

[ocean90]

Refreshed

[nacin]

We don't have ajax deletion of posts, so I don't think the lack of ajax on media is serious here. Patch isn't internationalized. Not a serious or immediate regression, so I'm punting.

[SergeyBiryukov]

Related/duplicate: #19052, #19363

[ocean90]

Obsolete through media revamp in 3.5.