Opened 15 years ago
Closed 12 years ago
#13502 closed defect (bug) (invalid)
Ajax deletion of media broken due to Trashing remains
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 2.9 |
Component: | Media | Keywords: | |
Focuses: | Cc: |
Description
To reproduce:
- Upload a file
- Expand to view file details
- Click Delete, Follow through.
Result: Page reloads and deletes the object
Expected Result: At some point here, Ajax deletion is supposed to kick in.
prepareMediaItemInit()
in swfupload handlers.dev.js contains some Ajax trash/undo code, which is never hit, It looks like it was never removed when the Media trashing code was striped out.
Attachments (5)
Change History (19)
#3
@
15 years ago
- Keywords has-patch added; needs-patch removed
- Severity changed from minor to normal
- added trashSuccess and trashError
- revert old deleteSuccess and deleteError
- fix nonce bug
No it works with MEDIA_TRASH and without.
#4
@
15 years ago
- Milestone changed from 3.0 to 3.1
Not a regression so moving to 3.1. Need to get review from azaozz since he knows the full history here.
#6
@
15 years ago
- Keywords media added
Updated patch and closed #13846 as dup, because it's fixed with this patch.
#8
@
15 years ago
- Keywords needs-refresh added; has-patch media removed
I will create a new patch so azaozz can review it.
#9
@
15 years ago
- Keywords has-patch added; needs-refresh removed
- Owner changed from ocean90 to azaozz
- Status changed from accepted to assigned
The patch works with define('MEDIA_TRASH', true);, define('EMPTY_TRASH_DAYS', 0); and without too.
#11
@
15 years ago
- Keywords needs-patch added; has-patch removed
- Milestone changed from 3.1 to Future Release
We don't have ajax deletion of posts, so I don't think the lack of ajax on media is serious here. Patch isn't internationalized. Not a serious or immediate regression, so I'm punting.
Media trashing was removed in 2.9, or at least, the UI for it was. The backend code has been left in place for when it was to be fully integrated, hopefully with 3.0. That hasnt happened however.
Given that this was broken in 2.9 i would assume now, This probably isnt that high of a priority for 3.0, If someone can provide a patch, go for it.