WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#13515 closed defect (bug) (fixed)

Wrong button label on edit-link-categories.php

Reported by: jane Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: UI Keywords: text, button, label, has-patch
Focuses: Cc:

Description

If you open quick edit on an item at edit-link-categories.php, the submit button is labeled "Update Tag" instead of "Update Category" as it is on the regular screen to edit a link category. Please change button text; I don't think we even need the noun. Just "Update" works for me.

Attachments (2)

wp_13515_stas.diff (711 bytes) - added by sushkov 5 years ago.
13515.diff (1005 bytes) - added by duck_ 5 years ago.

Download all attachments as: .zip

Change History (7)

@sushkov5 years ago

comment:1 @sushkov5 years ago

  • Cc sushkov added
  • Keywords has-patch added

@duck_5 years ago

comment:2 follow-up: @duck_5 years ago

Didn't refresh before I uploaded patch. The first patch here will change the text on tag quick edit (e.g. edit-tags.php?taxonomy=post_tag) to "Update" too, whilst normal categories stay as "Update Category". Maybe a full review of terms used?

comment:3 @hakre5 years ago

This might need gettext context, but I'm not sure (_x, _nx).

comment:4 in reply to: ↑ 2 @duck_5 years ago

Replying to duck_:

Maybe a full review of terms used?

Though I think changing default strings now would be unnecessary and probably too late for 3.0. What I was trying to highlight was the fact that some other text for link categories might be wrong seeing as it's defined as non-hierarchical.

comment:5 @ryan5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [14841]) Fix update label for link categories. Props duck_. fixes #13515

Note: See TracTickets for help on using tickets.