Undefined variable $recurse_start when creating a new menu

[ocean90]

Multisite, global terms enabled.

Notice: Undefined variable: recurse_start in H:\xampplite\htdocs\wp\wp-includes\ms-functions.php  on line 1260

I get this message when I create a new menu. Maybe use isset() or set $recurse_start by default true/false.

[nacin]

Not sure if recurse_start should be true or false by default. Alternative is to add an isset check. Assigning to Ron for review and commit.

[nacin]

I'm not really sure what's going on with the logic there at all. What happens when $global_terms_recurse is greater than 10?

Also, we can make that a static variable instead of a global variable.

[wpmuguru]

I'm having a look at this now.

Replying to nacin:

I'm not really sure what's going on with the logic there at all. What happens when $global_terms_recurse is greater than 10?

Also, we can make that a static variable instead of a global variable.

The 10 is a limit to prevent a race condition. If it hits 10 conflicts between local terms and global terms, it stops trying to sync.

[wpmuguru]

(In [14866]) eliminate warning in global_terms(), global to static, fixes #13517

[wpmuguru]

have to apply another patch to this.

[wpmuguru]

(In [14867]) give static var initial value, fixes #13517