WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#13520 closed defect (bug) (fixed)

Inaccurate Menu Locations Label

Reported by: filosofo Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: Menus Keywords: has-patch
Focuses: Cc:

Description

Label says to select the location when it's the menu being selected.

Attachments (2)

accurate-location-label.13520.diff (1.0 KB) - added by filosofo 5 years ago.
accurate-location-label.13520.2.diff (904 bytes) - added by filosofo 5 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 follow-up: @johnonolan5 years ago

+1 good catch

I would suggest changing the singular statement to "select which menu you would like to use"

Assuming that %2$s is the location name defined by the theme, this could lead to grammatically questionable sentences such as "select which menu appears in Primary" or "select which menu appears in Navigation"

comment:2 in reply to: ↑ 1 @filosofo5 years ago

Replying to johnonolan:

Assuming that %2$s is the location name defined by the theme, this could lead to grammatically questionable sentences such as "select which menu appears in Primary" or "select which menu appears in Navigation"

What if we put quotation marks or italics around the location name?

comment:3 @johnonolan5 years ago

Yep, that could work - but if there's only one option anyway then there's no need to specify it by name really.

If there were two plates on a table I might say to you "could you pick up the blue plate" but if there was only one plate there I would just say "could you pick up the plate".

I don't know if one might lend itself more to translation than the other - I'll see if I can find demetris

comment:4 @filosofo5 years ago

OK, let's just use your suggestion. It's simpler and not as much risk of confusion.

comment:5 @filosofo5 years ago

As in the second patch, I meant to say.

comment:6 @automattor5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [14846]) Better text for locations box. Props filosofo. fixes #13520 see #13378

comment:7 @demetris5 years ago

  • Cc dkikizas@… added

@johnonolan

Such strings are usually easy for translation. The difficult part is to find a good original string, something at which we are not exceptionally good as of late: some new strings are too verbose or too complicated.

For the two strings discussed here I would simply use:

Select menu to use in your theme.

and

Select menus for the menu locations of your theme.

I think I would also change the metabox title, which I find confusing, to:

Menu Locations

Note: See TracTickets for help on using tickets.