WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#13551 closed defect (bug) (fixed)

Classes Menu Item Property Should be array

Reported by: filosofo Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: Menus Keywords: has-patch
Focuses: Cc:

Description

  • We use it as an array almost everywhere.
  • PHP array functions are pretty quick.
  • This reduces some of the kludgy parts of the code and makes it consistent.
  • There are a ton of classes on the public menu items that no doubt people will be filtering. Best not to make them have to explode by whitespace and then do array-handling: let's just make it arrays all the way.

Attachments (1)

make-classes-property-consistent.13551.diff (8.2 KB) - added by filosofo 4 years ago.

Download all attachments as: .zip

Change History (2)

comment:1 ryan4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [14944]) Make classes property for menus an array. Props filosofo. fixes #13551

Note: See TracTickets for help on using tickets.