GUID and feed issues with custom post types

[nacin]

1. With rewrite => true, all posts of a custom post type will get the same guid. Aside from being a Bad Thing, this breaks feeds in particular (looks like Safari cares deeply).

2. With ugly permalinks, the feed won't validate. Seems to be annoyed with the underscore, or something: <link>http://localhost/commit/?post_type=manager&p=45</link>

[beaulebens]

In your example for 2), I imagine it's unhappy about "&" which needs to be encoded in XML.

[westi]

Replying to beaulebens:

In your example for 2), I imagine it's unhappy about "&" which needs to be encoded in XML.

That would make perfect sense.

[nacin]

Yep. We've never previously had & there, even ugly links.

Currently tracking down the first issue. Looks like get_permalink() is returning just ​http://localhost/commit/manager/ when generating an auto-draft.

[westi]

(In [14947]) Escape the guid urls when placing them in feeds and other xml locations. See #13555.

[wmrom]

Why can't we omit the post type altogether? using just ?p=<post_ID> in the url gives you the right page, and the post_ID is, de facto, unique.

[nacin]

Replying to wmrom:

Why can't we omit the post type altogether? using just ?p=<post_ID> in the url gives you the right page, and the post_ID is, de facto, unique.

Hrm. It doesn't on my install, though it should. There should be a canonical redirect, the same way p=2 goes to page_id=2.

[nacin]

(In [14948]) Consider 'auto-draft' a draft in get_post_permalink(). prevents custom post types from getting borked GUIDs. see #13555

[westi]

(In [14949]) Move the escaping into get_guid() so we don't have to repeat ourselves. See #13555.

[westi]

(In [14950]) Some more url escaping in feeds. See #13555.

[nacin]

(In [14952]) Final bit of escaping in feeds. fixes #13555

[hakre]

MINOR: some whitespace

[hakre]

MINOR: Little cleaning up behind. Reopen for that, close if you see unfit or just commit.

[nacin]

(In [15264]) Two birds with one stone. fixes #13902, props ocean90, wahgnube. fixes #13555, props hakre.