Make WordPress Core

Opened 20 years ago

Closed 20 years ago

Last modified 19 years ago

#1357 closed defect (bug) (fixed)

/page/1/ is redundant information

Reported by: denis-de-bernardy's profile Denis de Bernardy Owned by: markjaquith's profile markjaquith
Milestone: Priority: normal
Severity: trivial Version: 1.5.1
Component: Template Keywords: bg|has-patch bg|commit
Focuses: Cc:

Description

in the next/prev posts and post page links, paged=1 is redudant information.

Attachments (1)

template-functions-links.16.php.diff (842 bytes) - added by markjaquith 20 years ago.
Patch against 1.6 SVN

Download all attachments as: .zip

Change History (8)

#1 @Denis de Bernardy
20 years ago

  • Patch set to No

#2 @matt
20 years ago

Agreed.

#3 @Denis de Bernardy
20 years ago

i think it could cause damage, too: odds are googlebot might consider this a page with two addresses, i.e. spam

#4 @MC_incubus
20 years ago

  • Patch changed from No to Yes

The patch I uploaded is dependent on this patch:
http://mosquito.wordpress.org/view.php?id=1362

Otherwise, use $qstr = add_query_arg('paged', , $qstr); instead of remove_query_arg(), which is useless without the patch on 1362.

I did basic testing with mod_rewrite/query style setups and it seemed to work, but I'd appreciate testing. Basically, if $pagenum === 1, it does str_replace('page/1/', , $qstr); and remove_query_ary('paged', $qstr); to remove both the mod_rewrite and query style versions of the "first page."

@markjaquith
20 years ago

Patch against 1.6 SVN

#5 @markjaquith
20 years ago

  • Keywords bg|has-patch bg|commit added
  • Milestone set to 1.6
  • Owner changed from anonymous to markjaquith
  • Status changed from new to assigned

#6 @matt
20 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [2803]) Fixes #1357

#7 @(none)
19 years ago

  • Milestone 2.0 deleted

Milestone 2.0 deleted

Note: See TracTickets for help on using tickets.