Updating custom fields fails

[ampt]

When trying to update a custom field for a post or page it fails to update the new value.

Undefined index: _ajax_nonce-add-meta in/wp-includes/pluggable.php on line 848

check_ajax_referer seems to be looking for _ajax_nonce-add-meta in $_REQUEST
when it actually has _ajax_nonce

Should there be an isset check on the $_REQUEST variable?

if ( isset($_REQUEST[$query_arg]) )
    $nonce = $_REQUEST[$query_arg];

[nacin]

I wrote this originally a few days ago, and tested it. I can't reproduce this. It looks like both _ajax_nonce and _ajax_nonce-add-meta is getting sent, though it should only be the latter. Point is, it should be set.

_ajax_nonce=0&action=add-meta&metakeyselect=Blah&metakeyinput=&metavalue=BLAH&_ajax_nonce-add-meta=a431bb01f8&post_id=139

Any plugins? (Can you disable them and test?) Browser? Try an upgrade again? Of note, it also works fine with JS.

Lowering severity pending feedback.

[nacin]

Ref: [14933]

[ampt]

I tested this on a fresh install from trunk with no plugins, fresh database. Also tested in Firefox, Safari & Chrome and I still seem to be getting the undefined index notice. The error message shows up in the ajax-response div.

Here is what I have getting sent:

_ajax_nonce=1c8e646170&action=add-meta&meta%5B3%5D%5Bkey%5D=test&meta%5B3%5D%5Bvalue%5D=test-value&post_id=1

I will keep looking into it

[nacin]

Works on add, not on update.

[nacin]

(In [15028]) Fix nonce check for updating custom fields. fixes #13586.