Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#13588 closed defect (bug) (duplicate)

Continue Reading apears unecesarily on the Twenty Ten attachent page

Reported by: tomthewebmaster Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.0
Component: General Keywords:
Focuses: Cc:


Recently, I uploaded an image to WordPress, and typed in a caption and a description to go along with it.

Later, I went to view this image on its attachment page in Twenty Ten, using RC1. My description and caption were both simply "Test". "Continue Reading" appeared after the first caption, even though there was no additional text to continue reading.

I would assume this is involves use of the_excerpt(); on line 89 of attachment.php.

I have attached a picture of this. Let me know if anyone has any questions. Thanks.

Attachments (1)

screenshot1.jpg (60.8 KB) - added by tomthewebmaster 5 years ago.

Download all attachments as: .zip

Change History (3)

@tomthewebmaster5 years ago

comment:1 @nacin5 years ago

  • Milestone 3.0 deleted
  • Resolution set to duplicate
  • Status changed from new to closed

This is indeed due to the_excerpt().

I had discussed this with iandstewart (via IRC, cross-reference is #13361) that there are a few cases for "Continue reading..."

  • Manual (user-provided) excerpt. These will not be cut by the_excerpt() but should have "Continue reading..." appended.
  • Automatic excerpt that is trimmed. This triggers the excerpt_more filter, so we can change [...] to ..., and append "Continue reading..."
  • Excerpt that matches the content (may be automatic, or manual). If automatic, this means the content is too short to need a trim. We can still append "Continue reading..." because there's more things on the single page (comments, etc.) and as it is consistent with the others (though not needed).

I'm going to re-open #13361 so we can ponder it further and close this one as a duplicate. I think Ian's last patch might be a better solution.

comment:2 @hakre5 years ago

I now re-opened #13361 again because it was said it was fixed, but for me on current trunk it was not.

Note: See TracTickets for help on using tickets.