WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #13590, comment 4


Ignore:
Timestamp:
01/19/11 09:50:37 (5 years ago)
Author:
aercolino
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #13590, comment 4

    initial v1  
    13131. Does this solution fail sometime? 
    1414I've no clear answers, but hints.  
    15 1. The escaping/unescaping are cheap operations, but they do examine a string char by char. In this use case, I already short-circuited any char MySQL can handle by itself (3 bytes UTF-8). 
     151. The escaping/unescaping are cheap operations, but they do examine a string char by char. In this use case, I already short-circuited any char MySQL can handle by itself (1 to 3 bytes UTF-8). 
    16161. Only strings are escaped/unescaped, the rest is short-circuited (at least when writing to the db, when reading all is a string), so I think that only a binary string could cause some troubles. 
    1717I'd like to know your thoughts, and if the patch could find its way into some next (close) WP release.