Changes between Initial Version and Version 1 of Ticket #13590, comment 4
- Timestamp:
- 01/19/2011 09:50:37 AM (14 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #13590, comment 4
initial v1 13 13 1. Does this solution fail sometime? 14 14 I've no clear answers, but hints. 15 1. The escaping/unescaping are cheap operations, but they do examine a string char by char. In this use case, I already short-circuited any char MySQL can handle by itself ( 3 bytes UTF-8).15 1. The escaping/unescaping are cheap operations, but they do examine a string char by char. In this use case, I already short-circuited any char MySQL can handle by itself (1 to 3 bytes UTF-8). 16 16 1. Only strings are escaped/unescaped, the rest is short-circuited (at least when writing to the db, when reading all is a string), so I think that only a binary string could cause some troubles. 17 17 I'd like to know your thoughts, and if the patch could find its way into some next (close) WP release.