Menu Hierarchy not saving correctly (video)

[nathanrice]

I was playing with the 3.0RC and noticed a bug when I was building a menu.

Basically, I added 3 top level pages ... then added 6 other pages which I made subpages of one of the original 3 top level pages ... then added 2 more pages, and made them subpages of another of the original 3 top level pages. Finally, I added 3 categories as top level.

When I saved the menu, the 6 subpages I added reverted to top level links, but the 2 other subpages I added maintained their hierarchy.

Please watch ​this video for a demonstration/explanation.

I don't know why this is happening. Probably over my head.

[nacin]

Also, "(Pending)" should be non-JS only if I recall our conversation correctly.

[nathanrice]

Replying to nacin:

Also, "(Pending)" should be non-JS only if I recall our conversation correctly.

Yeah, I thought that looked weird.

[nathanrice]

Also, I made a ​much shorter video demonstrating the bug. Sorry about that.

[duck_]

Somehow the Home item is messing with the ordering. Quick tests only happening for me when I add the Home item along with a bunch of other items which I place into an order.

[nacin]

Per duck_ in IRC, it's reproducible only when adding the Home link, and probably only for hierarchy created on the same pageload as the home link. We have special code that always inserts the home link to the top. I imagine it is also only reproducible when the home link is added along with other pages at the same push of the "Add to Menu" button.

Simple solution would probably be to remove our toTop() code. It feels odd to do that anyway now that it is built in to Pages > View All instead of being its own separate step/link/function. (Then again, some people may find the admin to be smart for inserting Home at the top.)

[nacin]

(In [15049]) Sanity check menu item parents and fix HTML issues. props filosofo, fixes #13600.