Multi-Site -> Media: Incorrect Max Upload Size

[brandondove]

"Maximum upload file size" value in the add media box is being pulled from the Network Options->Site upload space even when it's unchecked. Seems like it shouldn't show the restriction or instead show the php ini value in this scenario.

[brandondove]

Shows unchecked "Site upload space" option

[brandondove]

Shows the incorrect results in the media upload thickbox

[wpmuguru]

Are you using the RC?

[wpmuguru]

I tested with the RC and got the PHP file size limit. If you have the issue with the RC, please re-open and include what your netowrk options & PHP settings are.

[mture]

I have come across the same issue with my WordPress 3.0.1 installation.

My PHP settings (from php.ini) are:

post_max_size = 200M
upload_max_filesize = 200M

My WordPress Network Options -> Upload Settings are:

Site upload space: unchecked, 10MB
Max upload file size: 204800KB

With these settings, the Maximum upload file size hint message in the Add an Image dialog box will display a max size of 10MB.

If I change the value of Site upload space to 5000MB (still unchecked), then the hint message will correctly show a max size of 200MB, reflecting the PHP limits.

[mture]

Adding myself to the 'cc' list.

[sillybean]

I just encountered this as well in a nightly build from a few weeks ago. I forget which one; the db version is 15477.

post_max_size = 150M
upload_max_filesize = 150M

Site upload space: unchecked, 10MB
Max file upload size: 150000KB

The uploader screens all showed (and enforced) a 10MB limit until I increased the site upload space value, leaving it unchecked.

[hakre]

What does the "unchecked" mean? That the site upload space should be reflected in the limit?

[sillybean]

hakre, if that option is not checked, I would expect that the limit in the text input would not be enforced -- in other words, that there would be no upload limit specific to WordPress, and the php.ini settings would be used instead.

[wpmuguru]

If the space limit for a specific sub-site is 20MB, then the upload limit in the uploader should enforce that even if the PHP limit is higher. Otherwise, the setting is misleading.

A use case would be a network where default limit is 20MB & the user can purchase an upgrade to 2GB. In this scenario, the network admin might want to allow a full 2GB upload for the upgraded accounts and set the PHP limit accordingly. Without the individual sub-site setting, the network admin has no easy way to enforce the lower limit.

[nacin]

Going to try to review this today. If I don't fix it, or have a chance to review it, I am punting it.

If you care about this bug, please review it and look into it. I will otherwise very likely punt it.

[ryan]

Punting all tickets that are not regressions in 3.1.

[nacin]

This is a 3.0 regression (might have been in MU but I don't think so). The fix is small enough that Ryan can go for it. Moving back to 3.1 for now.

[sillybean]

Patch tested, works beautifully.

[wpmuguru]

That patch looks fine for me. With it applied, the uploader still observed either the PHP max size or the upload max size in the network settings (whichever was smaller).

[nacin]

(In [17085]) Don't check the upload space site option if the option is disabled. props greuben, fixes #13601.