WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#13621 closed defect (bug) (fixed)

Post type doesn't appear in nav menu, even if setting show_in_nav_menus

Reported by: maorb Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: Posts, Post Types Keywords: reporter-feedback
Focuses: Cc:

Description

Hi,

I've just downloaded the WP3.0RC1 and found that a new post type I created does not appear for selection the the menu navigation page.
I added the show_in_nav_menus => true to my register_post_type function, and also this custom post type has been definedas public and also to show_ui. But still, this post type does not appear in the nav menus.

Is this a bug or there was a change in the array keys that needs to be used to achieve that?

Change History (7)

comment:1 @michaelh5 years ago

Assuming that you do have properly registered custom post types, then have you checked the Screen Options under Appearance->Menus to make sure that your custom post type is checked?

comment:2 @nacin5 years ago

  • Keywords reporter-feedback added; custom post types nav menus removed

If it's not under Screen Options, please provide your register_post_type function call, including the hook it is attached to.

comment:3 @nacin5 years ago

  • Priority changed from high to normal
  • Severity changed from major to normal

comment:4 @nacin5 years ago

(In [15056]) Use show_in_nav_menus for attachments. Also add it to register_taxonomy for consistency and have it default to public, not show_ui, like post types. see #13621.

comment:5 follow-up: @maorb5 years ago

ok... shame on me :-) haven't thought to look inside the Screen Option and that the post type needed to be checked there.
Checked it and it's all ok now.
Anyway, I think it's not so intuitive for the user, and I assumes that if the show_in_nav_menus is set to true, then the post type should be auto visible without checking the Options in the post type. Kinda duplicated, isn't it?

Thanks anyway

comment:6 @maorb5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

comment:7 in reply to: ↑ 5 @nacin5 years ago

Replying to maorb:

Anyway, I think it's not so intuitive for the user, and I assumes that if the show_in_nav_menus is set to true, then the post type should be auto visible without checking the Options in the post type. Kinda duplicated, isn't it?

Generally speaking the user would not be doing both post type registration AND menu management. One is a user action, the other is a developer action. The point is for the post type to say what it is capable of and that's about it. With regards to menus, we made a decision a while ago to limit the initial display to only pages and categories, and bury the rest in screen options.

That changeset doesn't fix a bug here cause there isn't one here, but I wanted to do it anyway. Closing as fixed in that case, otherwise we would close this as invalid or worksforme.

Debating whether it was a good idea however to switch to defaulting to public versus show_ui, but I wanted it to be consistent with post types.

Note: See TracTickets for help on using tickets.