twentyten top margin css fix
|Reported by:||Ornani||Owned by:||iammattthomas|
While creating a new twentyten child theme for a client, I had to override the header.php file to add some stuff to the top of the page. Until now - everything is cool.
I encountered many CSS issues which all disappeared the moment I found out how the top 20px margin is applied.
The most intuitive thing is to think that the #wrapper div has a "margin-top:20px". This is not the case. The margin is applied on the #header div. It took me quite a while to figure this one out.
I don't know why this has been done, but I know it's going to confuse and cause problems for developers.
Also, IE6 and IE7 are not implementing the top margin property when assigned the current way, and using my solution, it works.
My suggestion is to move the margin-top property from the #header div to the #wrapper div.
Thank you for doing your awesome work with WordPress,
Change History (16)
- Keywords has-patch added; margin-top margin css twentyten ie ie6 ie7 removed
- Owner set to iammattthomas
- Status changed from new to reviewing