Do not show a 404 title on wp-activate.php

[ocean90]

Reported by ​mngreg:

I noticed one very small thing while testing: When I clicked the activation link in the e-mail that was sent to me after I signed up, the title of that page it took me too was "Not Found," though everything worked fine and the page content included the confirmation message, etc.

[wpmuguru]

I'm not able to reproduce the 404 title on activation in either a subdomain or folder install.

[wpmuguru]

Occurs when custom permalinks are set.

[ocean90]

Set is_home = true to get name+description as title, same for wp-signup.php

[westi]

A better fix for this would be to add some rewrite rules to the internal rewriter so that it matches for the request.

I just tested with the following hacked in in the right place and the direct setting of $wp_query attributes removed.

$robots_rewrite['.*wp-signup.php$'] = $this->index . '?signup=true';
$robots_rewrite['.*wp-activate.php$'] = $this->index . '?activate=true';

That kind of thing does the trick.

We need to decide how we want them to rewrite though.

[wpmuguru]

@ocean90: we don't want to be setting $wp_query variables directly like that. Even though we aren't requiring php5, we should observe class abstraction where we can.

[wpmuguru]

13638.3.diff works. Since activation & signup are not looking for posts/pages. I don't see the point of running through the rewrites checking for matches. Are there reasons we wouldn't want to apply that patch?

[nacin]

I like westi's approach. 13638.3.diff seems like a patch that could break some very peculiar deep integration use cases and shouldn't go in during an RC.

[wpmuguru]

teh rewrites for review

[westi]

That last patch looks great :-)

[wpmuguru]

(In [15081]) add rewrites for registration pages, fixes #13638

[wpmuguru]

Quick note for anyone following the ticket - you need to flush your rewrite rules before that change takes effect.

[nacin]

I bumped the db version in [15084] to trigger a flush for this.