WordPress.org

Make WordPress Core

Opened 5 years ago

Last modified 14 months ago

#13657 assigned enhancement

When WP_DEBUG is true show better errors for establishing database connection

Reported by: sivel Owned by:
Milestone: Future Release Priority: low
Severity: trivial Version:
Component: Database Keywords: has-patch
Focuses: Cc:

Description

Right now no matter if WP_DEBUG is enabled or not we always show some generic errors for Error establishing a database connection

We should display the specific error when WP_DEBUG is enabled.

Attachments (1)

13657.diff (2.6 KB) - added by sivel 5 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 @sivel5 years ago

Patch is just an idea of how we might do this. Open to other suggestions and patches.

@sivel5 years ago

comment:2 @nacin5 years ago

I would tend to think we should not be exposing the output of mysql_error() on any site. Or, if we do, then we at least also check for display_errors/WP_DEBUG_DISPLAY, in case they want WP_DEBUG (as can be common in production) but are logging it.

comment:3 @nacin5 years ago

  • Keywords early removed

comment:4 @nacin5 years ago

  • Milestone changed from Awaiting Triage to Future Release

comment:5 @sivel5 years ago

The way that translations are handled for these errors makes it difficult to do conditionals like this. Mainly due to duplicating large portions of code and strings. Well maybe not large but more than I am comfortable with duplicating.

I may just need to stare at the code for a bit to get a creative solution, that is unless someone has recommendations.

comment:6 @mbijon3 years ago

  • Cc mike@… added

comment:7 @ryan14 months ago

  • Owner ryan deleted
  • Status changed from new to assigned
Note: See TracTickets for help on using tickets.