WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#13692 closed defect (bug) (fixed)

Twenty Ten: Enhancement to class name nopassword

Reported by: zeo Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch commit
Focuses: Cc:

Description

Add the same padding value as id name comments-title so that we keep the gap consistency. see: class-nopassword-padding.diff and image attached.

Use p element instead of div for class name nopassword so that we keep the element consistency used by class name nocomments. Since both are wrapped by the same element - div#comments. see: class-nopassword-use-p.diff

Currently this is how it's structured:

<div id="comments">
   <div class="nopassword">...</div>
</div>
<div id="comments">
   <p class="nocomments">...</p>
</div>

Attachments (3)

nopassword.jpg (25.6 KB) - added by zeo 5 years ago.
Comparison before and after clockwise.
class-nopassword-padding.diff (348 bytes) - added by zeo 5 years ago.
Add the same padding value as id name comments-title.
class-nopassword-use-p.diff (696 bytes) - added by zeo 5 years ago.
Use p element instead of div for class name nopassword.

Download all attachments as: .zip

Change History (6)

@zeo5 years ago

Comparison before and after clockwise.

@zeo5 years ago

Add the same padding value as id name comments-title.

@zeo5 years ago

Use p element instead of div for class name nopassword.

comment:1 @nacin5 years ago

  • Keywords commit added; 2nd-opinion removed

I see no problems with using <p>.

comment:2 @nacin5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [15121]) Use p.nopassword instead of div.nopassword in Twenty Ten. props zeo, fixes #13692.

comment:3 @nacin5 years ago

(In [15125]) Hide 'no password' text for comments. It's already being shown for the_content; aligns it with .nocomments; fixes #13692.

Note: See TracTickets for help on using tickets.