WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#1370 closed defect (bug) (fixed)

Presentation page crashing when a theme directory is not readable by the web server

Reported by: neuro Owned by: markjaquith
Milestone: Priority: normal
Severity: critical Version: 1.5.1
Component: Administration Keywords: bg|has-patch bg|commit
Focuses: Cc:

Description

Theme folder browsing does not care wheter or not the theme directory is readable before reading into it.
This makes th admin page crash as soon as a theme is not readable.
replace line 1517 in functions.php
if (is_dir($theme_root . '/' . $theme_dir)) {
by
if (is_dir($theme_root . '/' . $theme_dir) && is_readable($theme_root . '/' . $theme_dir)) {

Attachments (1)

functions.php.diff (545 bytes) - added by markjaquith 9 years ago.
patch for 1.6 SVN

Download all attachments as: .zip

Change History (7)

comment:1 neuro9 years ago

  • Patch set to No

comment:2 ryan9 years ago

  • Milestone set to 1.6
  • Owner changed from anonymous to ryan

markjaquith9 years ago

patch for 1.6 SVN

comment:3 markjaquith9 years ago

  • Keywords bg|has-patch bg|commit added

comment:4 markjaquith9 years ago

  • Owner changed from ryan to markjaquith
  • Status changed from new to assigned

comment:5 matt9 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [2740]) Fixes #1370

comment:6 anonymous7 years ago

  • Milestone 2.0 deleted

Milestone 2.0 deleted

Note: See TracTickets for help on using tickets.