WordPress.org
Get WordPress

Make WordPress Core

Opened 20 years ago

Closed 19 years ago

Last modified 18 years ago

#1370 closed defect (bug) (fixed)

Presentation page crashing when a theme directory is not readable by the web server

Reported by: neuro's profile neuro Owned by: markjaquith's profile markjaquith
Milestone: Priority: normal
Severity: critical Version: 1.5.1
Component: Administration Keywords: bg|has-patch bg|commit
Focuses: Cc:

Description

Theme folder browsing does not care wheter or not the theme directory is readable before reading into it.
This makes th admin page crash as soon as a theme is not readable.
replace line 1517 in functions.php
if (is_dir($theme_root . '/' . $theme_dir)) {
by
if (is_dir($theme_root . '/' . $theme_dir) && is_readable($theme_root . '/' . $theme_dir)) {

Attachments (1)

functions.php.diff​ (545 bytes) - added by markjaquith 19 years ago.
patch for 1.6 SVN

Download all attachments as: .zip

Change History (7)

#1 @neuro
20 years ago

  • Patch set to No

#2 @ryan
19 years ago

  • Milestone set to 1.6
  • Owner changed from anonymous to ryan

@markjaquith
19 years ago

patch for 1.6 SVN

#3 @markjaquith
19 years ago

  • Keywords bg|has-patch bg|commit added

#4 @markjaquith
19 years ago

  • Owner changed from ryan to markjaquith
  • Status changed from new to assigned

#5 @matt
19 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [2740]) Fixes #1370

#6 @(none)
18 years ago

  • Milestone 2.0 deleted

Milestone 2.0 deleted

Note: See TracTickets for help on using tickets.