dbDelta produces warnings

[mitchoyoshitaka]

I just followed the instructions ​on the Codex to use dbDelta to create and update tables, and I'm getting the following warning:

Warning: array_search() [function.array-search]: Wrong datatype for second argument in /Users/mitcho/wordpress/wp-admin/includes/upgrade.php  on line 1526

It looks like $indices is never being initialized as an array. The attached patch works, but I'm not familiar with the dbDelta logic so it'll need review from someone who does.

[nacin]

What's the table statement?

[mitchoyoshitaka]

Replying to nacin:

What's the table statement?

Here's my code:

		require_once( ABSPATH . 'wp-admin/includes/upgrade.php' );
		
		$dbSql = array(
						"CREATE TABLE `{$this->db_prefix}visitors` (
							`visitor_id` INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY ,
							`cookie` BINARY(16) NOT NULL UNIQUE KEY ,
							`timestamp` TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP
						) ENGINE = MYISAM ;");
		dbDelta( $dbSql );

where of course $this->db_prefix actually resolved to something involving $wpdb->prefix. I'm using an array because there actually are multiple, but I can reproduce this even with that first query.

[westi]

Ok. I can reproduce this.

Investigating

[mitchoyoshitaka]

Replying to westi:

Ok. I can reproduce this.

Investigating

Thanks. :)

[westi]

Note to self: To reproduce I created the table using the above and then duplicating the fields.

[nacin]

Committing this now.

Mitcho, you'll actually have a separate issue with your create table statement, in that you'll end up with duplicate cookie indexes each time it runs.

The issue is that dbDelta is incredibly finicky and requires exacting specifications in some cases, and sometimes throwing a fight over whitespace. The Codex is pretty good about explaining this, and otherwise sticking to the queries that core use is a good bet.

In this case, defining UNIQUE KEY with the cookie field is causing dbDelta to keep creating indexes. I did not look into why, but moving UNIQUE KEY cookie (cookie) to its own line at the end of the statement fixed it.

[nacin]

really-needs-unit-tests :-)

[nacin]

(In [15210]) Reset variables back to empty arrays instead of unsetting them in dbDelta. prevents a warning. props mitchoyoshitaka, fixes #13715.