WordPress.org
Get WordPress

Make WordPress Core

Opened 14 years ago

Closed 14 years ago

#13719 closed enhancement (fixed)

Remove background color for default RSS widget icon

Reported by: lancewillett's profile lancewillett Owned by: azaozz's profile azaozz
Milestone: 3.0 Priority: low
Severity: minor Version: 3.0
Component: Widgets Keywords: has-patch
Focuses: Cc:

Description

See wp-includes/default-widgets.php line 740.

The RSS icon in the default RSS widget currently uses a style of background: orange; which shows up poorly on dark backgrounds.

Patch changes the rule to background: transparent; along with removing unneeded color rule.

Attachments (2)

rsswidget-13719.diff​ (870 bytes) - added by lancewillett 14 years ago.
black_rss.png​ (4.4 KB) - added by ocean90 14 years ago.

Download all attachments as: .zip

Change History (7)

@lancewillett
14 years ago

#1 @nacin
14 years ago

Screenshot I imagine would be quite useful here.

@ocean90
14 years ago

#2 @ocean90
14 years ago

  • Milestone changed from Unassigned to 3.0

Added a screenshot, should be harmless.

#3 @nacin
14 years ago

Does it even need background:transparent at that point? That is the default.

#4 @nacin
14 years ago

Also, it can become esc_attr, but not esc_attr_e, we can't echo there.

#5 @nacin
14 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [15192]) Don't specify a background for the default RSS widget's icon. props lancewillet, fixes #13719.

Note: See TracTickets for help on using tickets.