http_request() fails when passed an array for the $body parameter

[mdawaffe]

Passing an empty array to WP_Http::request in the body argument causes an error if the WP_Http_ExtHTTP transport is used:

WP_Http::request( $url, array( 'body' => array() ) );

Since the body is empty, it gets ignored and so does not get converted into a (string) http query; it's passed straight into

@http_request($r['method'], $url, $r['body'], $options, $info);

Which causes an error.

Attached sets empty bodies to the default (null).

[westi]

That looks sane.

Is this bug triggered by any core code or a popular plugin?

[mdawaffe]

Thanks for fixing the component/version.

It's triggered by a plugin I'm writing :)

I honestly don't know how often people will run into this bug because the HTTP extension is rarely installed. When it is installed, though, it's the preferred transport.

So it's possible a small number of people will get hit with this bug constantly and silently because of the error suppression on ​http://core.trac.wordpress.org/browser/trunk/wp-includes/class-http.php?rev=15144#L1216

[mdawaffe]

Replying to westi:

Is this bug triggered by any core code or a popular plugin?

I can find no chance of this occurring in core.

[nacin]

(In [16450]) WP_Http_ExtHTTP variable fix. Don't pass an empty array to http_request, props mdawaffe, fixes #13730.