WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#13744 closed defect (bug) (duplicate)

Fix edit comments invalid markup

Reported by: t31os_ Owned by:
Milestone: Priority: low
Severity: trivial Version: 3.0
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

I spotted this small error whilst writing a blog on my WordPress.com website this morning, and thought i'd check trunk for the error, and indeed it does exist.

edit-comments.php displays a table of comments, the comment column contains a div element with an ID of "submitted-on", and of course IDs should be unique, therefore we have invalid markup produced when more then one comment is on the page.

Patch attached changes the ID for a class.

If there's an existing ticket for this please close (i did search first).

I was unsure whether i should take ownership of the ticket, so please update as appropriate.

Attachments (1)

edit_comments_markup.patch (121.0 KB) - added by t31os_ 5 years ago.
Changes edit-comments.php and CSS to use class for submitted on

Download all attachments as: .zip

Change History (3)

@t31os_5 years ago

Changes edit-comments.php and CSS to use class for submitted on

comment:1 @nacin5 years ago

  • Milestone changed from Awaiting Triage to Awaiting Review

This still an issue?

Please omit compressed files from patches.

comment:2 @scribu4 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.