WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#13745 closed enhancement (fixed)

Twenty Ten: style.css comment form related cleaning, enhancement

Reported by: zeo Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Themes Keywords:
Focuses: Cc:

Description

1) Removed obselete CSS selector #respond dl, dt, dd that was added in [13180] for #form-allowed-tags which was later removed in [14689].

2) Added back margin top for .form-submit which was deleted in [13180]. This will add some gap in between #form-allowed-tags and .form-submit. see: comparison.png for before-> after comparison.

3) Add margin bottom to #respond. Added some gap after comment_form hook before the border. This issue easily spotted when replying to comment (with JS). <?php do_action( 'comment_form', $post_id ); ?> is just an output example if a plugin or theme using the hook. see: comparison.png for before-> after comparison.

Attachments (3)

comparison.png (36.3 KB) - added by zeo 5 years ago.
comparison.png
13745-style.css.diff (732 bytes) - added by zeo 5 years ago.
13745-style.css.2.diff (732 bytes) - added by zeo 5 years ago.
Patch for issue 1, 2 and 3. Refreshed against [15153], [15154], [15155]

Download all attachments as: .zip

Change History (5)

@zeo5 years ago

comparison.png

@zeo5 years ago

comment:1 @zeo5 years ago

Oops! Forgot to tick "Replace existing attachment..."

@zeo5 years ago

Patch for issue 1, 2 and 3. Refreshed against [15153], [15154], [15155]

comment:2 @zeo5 years ago

  • Keywords has-patch removed
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [15163]

Note: See TracTickets for help on using tickets.