Deprecate is_term, is_taxonomy, is_post_type for *_exists()

[nacin]

Simply too much confusion, even with proper Codex documentation. post_type_exists() explains a lot more than is_post_type() anyway.

We should reserve is_ for conditional tags as much as possible (aside from functions clearly unrelated such as is_user_logged_in).

I wouldn't mind seeing this in 3.0 final, all we're doing is throwing in a few deprecated functions that would wrap better-named functions.

[demetris]

+1

I just logged in to open this ticket, and saw you had already done it. :-)

I only have a small reservation about is_term() because, unlike the other two, this does a bit more than a simple term_exists().

[t31os_]

+1

I am inclined to agree with demetris though, is_term i'm not too fussed about, but both is_tax and is_post_type are not appropriately named.

I've just answered a thread relating to this very issue, where users were using is_post_type as a conditional statement, not user error really, it's misleading.

[demetris]

There seems to be a mistake in the patch:

deprecated.php redefines term_exists() instead of defining is_term() and making it call term_exists().

[nacin]

Patch refreshed. Thanks demetris.

Not sure if we were all in agreement on doing this now, I know westi liked this. Marking for commit and we can decide tomorrow.

[ryan]

(In [15220]) Deprecate is_term, is_taxonomy, is_post_type for *_exists(). Props nacin. fixes #13747

[westi]

(In [15230]) Fell the dead wood. No point keeping a function as deprecated we only just introduced. See #13747

[hakre]

That third function does not exists, I could only find a is_post_type_hierarchical() function so far that starts with is_post.

[demetris]

@hakre

The third function was:

@deprecated 3.0.0

@since 3.0.0

For this reason, westi removed it in r15230.

[hakre]

Replying to demetris:

@hakre

The third function was:

@deprecated 3.0.0 ..

Oh sure, that's what I thought as well, but I just wanted to explain why I removed it from the tickets title because it might become misleading.