Unable to filter title tag on 404 pages in TwentyTen.

[mfields]

There seems to be a bit of redundant logic in header.php which renders the "wp_title" filter useless. If the condition is removed, the title will read "Page not Found | Blog Title" for 404 pages but plugin developers will have the ability to change the value where needed.

[nacin]

I'm finding some of the things we're doing a bit redundant.

Patch does two things. The first would be removing redundant things that wp_title() can handle when called properly. The second is entirely unrelated, and fixes logic, formatting, and branching for displaying a custom background (and switches the background-attachment default to scroll, the CSS default).

[mfields]

Awesome! Thanks for removing the excess whitespace from the title tag as well, this was bothering me as well.

[nacin]

Went a different route entirely. Patch now hooks into wp_title()'s filter instead. Sad ugly code to address the weakness of one of our functions now looks like happy poetic code... to address the weakness of one of our functions. :-)

As an added benefit, we're now adding page numbers to paged singular views (we were previously only checking the $paged global, but we need to check the $page global sometimes).

Quite happy with this result. This is backwards compatible for child themes in that it won't break them, though twentyten_the_page_number() is now gone so any overrides of that is now useless. But it's more friendly for child themes now.

[nacin]

(In [15195]) Use wp_title() proper in Twenty Ten, and move the janky stuff to a filter. see #13751.

[nacin]

(In [15196]) Improve the custom background front-end callback. Also, background-attachment should default to scroll, not fixed. fixes #13751.

[hallsofmontezuma]

yay for aioseop.diff
:)