Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#13761 closed defect (bug) (fixed)

Undefined Registration function in MS

Reported by: filosofo Owned by: filosofo
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.0
Component: Multisite Keywords: needs-patch
Focuses: Cc:

Description (last modified by filosofo)

Several global multisite functions, defined in wp-includes/ms-functions.php, call WP functions (such as username_exists) that are defined in wp-includes/registration.php and hence are not defined by default in wp-includes/ms-functions.php.

Patch includes the required registration.php file where needed if not already included.

Attachments (1)

define-registration-function-before-use.13761.diff (1003 bytes) - added by filosofo 5 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 @filosofo5 years ago

  • Description modified (diff)

comment:2 @ryan5 years ago

I think username_exists() and some other functions should eventually move to user.php. In the meantime, do we really need to worry about this? Those functions are only called from wp-signup.php, which includes registration.php.

comment:3 @ryan5 years ago

  • Milestone changed from 3.0 to 3.1

Let's move everything into user.php and deprecate registration.php in 3.1.

comment:4 @filosofo5 years ago

  • Milestone changed from Awaiting Triage to 3.1
  • Owner set to filosofo
  • Status changed from new to accepted

comment:5 @nacin5 years ago

  • Keywords needs-patch added; has-patch removed

Easy patch.

comment:6 @jane5 years ago

@nacin: put your money where your mouth is, dude. :)

Joking aside, freeze hits in a few days, so if someone wants to patch this, now's the time.

comment:7 @nacin5 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [16009]) Move registration.php functions to user.php. Deprecate registration.php, everything is now included by default. fixes #13761.

Note: See TracTickets for help on using tickets.