get_the_date() to accept optional $post argument

[bigdawggi]

Currently the get_the_date() function only utilizes the global $post. Allowing this function to accept an optional $post object as an argument would be beneficial for getting the formatted date of any post.

[bigdawggi]

Patch for get_the_date() to accept optional $post arg.

[ryan]

We typically call get_post() and let it figure out whether to use the global.

No more enhancements for 3.0. Moving to 3.1.

[bigdawggi]

Thanks Ryan. I agree, I was just trying to trim the extra function calls; but after review it may not be worth the investment in time to set a precedent of allowing an optional $post arg in template tags, though I'll let you guys decide ;)

[solarissmoke]

Also cleaned up the code/docs a bit.

[barrykooij]

When will this be added to core?

[tanner m]

New patch.

[tanner m]

Hey guys! Just added a new patch here. Let me know if there is anything else you need.

[tanner m]

Fix doc block grammar and use more conventional $post = 0.

[adamsilverstein]

Slight doc block cleanup, add 'Optional' to description of $post variable

[adamsilverstein]

Replying to tanner m:

Hey guys! Just added a new patch here. Let me know if there is anything else you need.

Hey Tanner - this looks good, I added the word 'Optional' to the doc block description of the new $post variable, and also cleaned up the alignment a bit.

Thanks for contributing! A unit test would be nice here...

[adamsilverstein]

add a unit test

[adamsilverstein]

13771.2.2.diff​ Adds a unit test verifying that get_the_date() returns the expected date when passed a post id (apologies for the funky filename).

[tanner m]

Great, thanks Adam!

[nacin]

Nice work, tanner and adam. It looks like $post should also be passed to the get_the_date filter.

[adamsilverstein]

Replying to nacin:

Nice work, tanner and adam. It looks like $post should also be passed to the get_the_date filter.

Thanks & good point! Added $post to the filter in 13771.3.diff​ and added a doc block above the filter since I was touching it anyway.

[DrewAPicture]

13771.3.diff​ seems to be in order. @adamsilverstein: nice work on the hook docs!

[adamsilverstein]

Replying to DrewAPicture:

13771.3.diff​ seems to be in order. @adamsilverstein: nice work on the hook docs!

Yea! that is the first time i've written a hook doc you didn’t have to fix!

[nacin]

In 27380:

Let get_the_date() accept a post object.

props tanner-m, adamsilverstein, bigdawggi.
fixes #13771.