Warning and wrong blog prefix in get_most_active_blogs() and get_blog_list()

[ocean90]

1. In get_blog_list() and get_most_active_blogs() you get a warning:

   Notice: Undefined index: time in \wp-includes\ms-blogs.php on line 548
   

The reason is, $blogstime? will be never set and/or saved. The best would be here to use the Transient API, see the patches.

2. A regression: The main site doesn't have a wp_1_posts table anymore, it has wp_posts. Because of that get_blog_list() returns 0 posts for the main site. We should use $wpdb->get_blog_prefix($id) to avoid it.

[ryan]

That list could exceed the typical memcached object size limit. I'm not sure a transient will work here.

[ryan]

The only thing I see calling this is get_most_active_blogs(). I don't see anywhere that calls get_most_active_blogs(). How are you triggering this? The kindest thing we can do to those functions is kill them entirely. :-)

[ryan]

wpmu-admin.php used to call get_most_active_blogs() but no longer does.

[ryan]

I suggest stubbing these out and moving to ms-deprecated.php. Those queries are suicidal.

[ocean90]

deprecate these functions

[ryan]

(In [15168]) Deprecate get_most_active_blogs() and get_blog_list(). Props ocean90. fixes #13773

[ryan]

These are actually used by some, so lets restore them but leave deprecated.

[ryan]

(In [15170]) Resurrect get_blog_list() and get_most_active_blogs() but leave deprecated. Props ocean90. fixes #13773