Bug with Conditional GET in wp-blog-header.php not resolved

[netspy]

The patch for bug #1356 is IMO not correct. A conditional GET request with IF_NONE_MATCH will produce an PHP warning:

PHP Warning: strtotime() [<a href='function.strtotime'>function.strtotime</a>]: Called with an empty time parameter. in /.../wp-blog-header.php on line 139

Here my version of the patch:

if (($client_last_modified && (strtotime($client_last_modified) >= strtotime($wp_last_modified)))

($client_etag && ($client_etag == $wp_etag))) {

if ( preg_match('/cgi/',php_sapi_name()) ) {

header('Status: 304 Not Modified');
echo "\r\n\r\n";
exit;

} else {

if ( version_compare(phpversion(), '4.3.0', '>=') )

header('Not Modified', TRUE, 304);

else

header('HTTP/1.x 304 Not Modified');

exit;

}

}

This works fine with IF_MODIFIED_SINCE and IF_NONE_MATCH requests.