Hidden columns on Taxonomy management pages broken

[dd32]

• If you hide columns on a category page, the column headers are not hidden as expected, Row data is hidden however.
• If you hide columns on a category page, The columns are hidden
• The selection for hidden columns is global accross all taxonomies, If you hide a column on the Categories page, it applies to Tags & Custom taxonomies.
• Only the post_tag taxonomy edit page works "correctly"

Issues brought up upon testing of ​wp-testers: Adding categories (minor issue)

[dd32]

I've started working on this, but, Am not 100% sure what i'm doing with the current screen code, If someone else feels like stepping in, please go at it, at this rate it'll take me a few days..

[ryan]

The page passed to the AJAX handler is always edit-tags. Compare that to edit.php which passes edit-$post_type. edit-tags.php should probably pass edit-$taxonomy. So, setup the screen similar to how edit.php is handled.

[ryan]

That fixes most of it. After hiding a column and then reloading the layout is a bit off.

[ryan]

If you hide description, slug, and posts (leaving only the checkbox and name), the table header background color doesn't fill all the way across. Sometimes the lines separating each row are truncated.

[ryan]

(In [15175]) Make set_current_screen() taxonomy aware. Use current_screen when setting up table headers for edit-tags.php. see #13783

[ryan]

I think I fixed the layout problems mentioned above. This is looking pretty good now. Please test.

[dd32]

$current_screen is not set for Ajax requests, As a result, with WP_DEBUG enabled and adding terms, you'll get a Ajax error screen.. which highlights that $current_screen is null, and as a result, the hidden columns is unavailable.

[dd32]

Differnt tax's keep their separate hidden columns however.

Only thing i can see different, is that the id is now 'edit-post_tag' instead of 'edit-tags' and 'edit-category' instead of 'edit-categories', Which means any previous settings for hte hidden columns will go missing. - Maybe not worth considering, or maybe just rename the keys in the db update or soemthing

[ryan]

(In [15178]) Set the screen for add-tag ajax requests. see #13783

[ryan]

I don't think losing the hidden column settings is a big deal. It's only three columns. That's so few that I doubt most people bother hiding columns like they do with the edit posts screen, which has many more columns.

[dd32]

Quite agree its not worth worrying about.. I was only thinking of the data sitting around doing nothing :)

[ryan]

(In [15187]) Remove old hidden columns usermeta keys. fixes #13783