Make WordPress Core

Opened 14 years ago

Last modified 7 years ago

#13792 reopened defect (bug)

Invalid reply link from comment admin when comment nested level > max

Reported by: archon810's profile archon810 Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 2.9.2
Component: Comments Keywords: has-patch needs-unit-tests
Focuses: Cc:


I have a blog with nested comments enabled, max depth of 4. When the last level comment is posted, it no longer contains a Reply link.

However, in the Comment admin, the Reply link is still present. If used, this new reply will show up at the very bottom of the comment list once posted (even if other newer regular comments are entered, this new reply will still show up at the very bottom).

The bug is, basically, that Comment admin doesn't respect the max nested value.

Attachments (2)

ticket.13792.diff (1.6 KB) - added by pauldewouters 10 years ago.
ticket.13792.2.diff (1.8 KB) - added by pauldewouters 10 years ago.
Added comments and var init

Download all attachments as: .zip

Change History (17)

#1 @archon810
14 years ago

  • Cc admin@… added

#2 @ocean90
14 years ago

You will see the reply link also when threaded comments are disabled. So it's not only for the threaded comments.

#3 @markmcwilliams
14 years ago

If for example you increase the max nested value, or turn on threaded comments, then all-of-a-sudden these comments would probably move into their respected place(s), which I do like the idea of actually. What about looking at maybe allowing authors, admins, and that being able to extend past the maximum if they're needing to answer something specific?

#4 @ocean90
14 years ago

markmcwilliams, but then we must know if the theme support this.

#5 @nacin
14 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to worksforme
  • Status changed from new to closed

#6 @archon810
14 years ago

  • Resolution worksforme deleted
  • Status changed from closed to reopened

Wait, nacin, why was this closed? It is most definitely still broken in 3.0.1. Replying to a comment from admin will be always possible, no matter whether the Reply depth has been reached. It is not a feature for admins - it's a bug. 100%.

#7 @nacin
14 years ago

  • Keywords close added

Because: "You will see the reply link also when threaded comments are disabled. So it's not only for the threaded comments."

#8 @nacin
14 years ago

  • Milestone set to Awaiting Review

#9 @archon810
14 years ago

In case of threaded comments disabled, this doesn't present a problem - you only have one methodology behind replying and that is your message becomes last. The reply button on every post then acts as 1 single giant reply button.

However, in the case of threaded comments with a reached limit, there should most certainly not be a reply button in the wp-admin for the same reason there shouldn't be any on the live site. The logic is exactly the same, whether it's on wp-admin or live post - I don't understand why there's such resistance to acknowledging it's a bug.

In the first paragraph, I expect my comment to show up where it does, while in the 2nd, I don't - it creates broken conversations because you, on the admin side, don't know that the thread limit has been reached and just use the Reply link blindly. Your reply, however, ends up who knows where all the way at the end, and that is buggy and unexpected behavior.

#10 @nacin
14 years ago

  • Keywords needs-patch ux-feedback added; close removed
  • Milestone changed from Awaiting Review to Future Release

Your persistence is appreciated. You've presented solid rationale, and I'm convinced.

#12 @pauldewouters
10 years ago

Added a fix that hides the reply link if depth exceeds max depth

10 years ago

Added comments and var init

#13 @chriscct7
8 years ago

  • Keywords has-patch needs-unit-tests added; needs-patch removed

This ticket was mentioned in Slack in #design by karmatosed. View the logs.

7 years ago

#15 @karmatosed
7 years ago

  • Keywords ux-feedback removed

This ticket probably needs attention but it doesn't need ux-feedback, so going to remove the tag as this was discussed in this week's UX triage session.

Note: See TracTickets for help on using tickets.