WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#13803 closed defect (bug) (fixed)

Bad admin menu background for long names

Reported by: newkind Owned by: JohnONolan
Milestone: 3.0 Priority: high
Severity: normal Version: 3.0
Component: UI Keywords: needs-patch
Focuses: Cc:

Description

Hi,

I noticed that when you use long names for the button in the admin dashboard, the background positioning is messed up. Please see the attachment.

newkind

Attachments (4)

button.jpg (7.7 KB) - added by newkind 4 years ago.
Preview
13803.diff (547 bytes) - added by johnonolan 4 years ago.
Fixes #13803 - Screenshot http://cl.ly/1L66
menu-bits.gif (1.1 KB) - added by johnonolan 4 years ago.
menu-bits-rtl.gif (1.2 KB) - added by johnonolan 4 years ago.

Download all attachments as: .zip

Change History (12)

newkind4 years ago

Preview

comment:1 ocean904 years ago

  • Keywords jo added
  • Summary changed from Bad Admin Button Background to Bad admin menu background for long names

comment:2 ocean904 years ago

  • Keywords jo removed

comment:3 ocean904 years ago

  • Keywords needs-patch added

It's only on the active menu item: http://grab.by/4QF2

We have have a new background image, the image has and border-bottom-color #AAA (the image, not via CSS). If the menu name is longer we doesnt' repeat the image, we use the border-bottom color, in this case its #AAA (the dark grey).
Solution: Create an image that's a gradient (with no border at the bottom) and then set the background color to the lowest color in the image. That way the gradient would appear to continue if the text overflows.

comment:4 nacin4 years ago

  • Owner set to JohnONolan
  • Status changed from new to assigned

I've seen this #aaa color during load times sometime while the image is still getting rendered.

Assigning to JohnONolan for review; I'll send him a note.

comment:5 johnonolan4 years ago

Cool I'm on it!

comment:6 johnonolan4 years ago

  • Component changed from Graphic Design to UI
  • Priority changed from normal to high

johnonolan4 years ago

Fixes #13803 - Screenshot http://cl.ly/1L66

comment:7 johnonolan4 years ago

Wrong screenshot - http://cl.ly/1Kxz that's the one.

johnonolan4 years ago

johnonolan4 years ago

comment:8 nacin4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [15206]) Fix admin menu background for long names. props JohnONolan, fixes #13803.

Note: See TracTickets for help on using tickets.