WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#13812 closed defect (bug) (fixed)

avoid displaying custom comment types as pingbacks/trackbacks in twentyten

Reported by: jdub Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: Themes Keywords: twentyten has-patch
Focuses: Cc:
PR Number:

Description

twentyten renders normal comments (comment_type == "") one way, and everything else as pingbacks.

this example patch avoids rendering custom comment types as pingbacks (or, in effect, at all).

obviously dealing with custom comment types will require more attention in the future, but this gets them out of twentyten's hair for the time being.

Attachments (1)

custom-comments-avoidance.diff (613 bytes) - added by jdub 9 years ago.
avoid rendering custom comments as pingbacks (diff against trunk)

Download all attachments as: .zip

Change History (10)

@jdub
9 years ago

avoid rendering custom comments as pingbacks (diff against trunk)

#1 @jdub
9 years ago

  • Keywords has-patch added

#2 @nacin
9 years ago

  • Milestone changed from Unassigned to 3.0

#3 @iammattthomas
9 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [15209]) Avoid displaying custom comment types as pingbacks/trackbacks in Twenty Ten. Fixes #13812. Props jdub.

#4 @jdub
9 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

My apologies, I should've put a comment here when nacin and I talked about this last night...

Rather than apply the quick-and-dirty patch I wrote, it would probably be better to use a switch statement (which neatly avoids the in_array call as a bonus). Should I write up a patch, or will you or nacin make the change?

(Reopening only to keep this on the agenda. Apologies if that's not the right thing to do.)

#5 @nacin
9 years ago

I told MT the patch was fine as is as it was trivial... I'll modify it however.

#6 @iammattthomas
9 years ago

Thanks, Nacin! :)

#7 @nacin
9 years ago

Matt, I'm noticing a double-border due to the bottom border of comments (or a pingback) and the top border of the #respond div. Can you confirm?

#8 @nacin
9 years ago

(In [15212]) Use a switch. props jdub, see #13812.

#9 @nacin
9 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Closing this as fixed. If MT or Ian want to review the double border, I've sent it to them in an email summarizing remaining 2010 tickets.

Thanks jdub and MT.

Note: See TracTickets for help on using tickets.