WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#13824 closed enhancement (fixed)

Twenty Ten: Posted in, Posted on i18n fix

Reported by: zeo Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: Themes Keywords: has-patch i18n-change commit
Focuses: Cc:

Description

Posted on:

  • Instead of <span %1$s> use <span class="%1$s"> for consistency. Making it clearer since there's no translators note.

Posted in:

  • Refer to patch. This was poorly and wrongly handle before.

Attachments (2)

13824-posted-in-on-i18n.diff (2.4 KB) - added by zeo 4 years ago.
Better Posted in, Posted on.
13824.2.diff (1015 bytes) - added by rovo89 4 years ago.
Extract meta-sep class from translated string

Download all attachments as: .zip

Change History (6)

zeo4 years ago

Better Posted in, Posted on.

comment:1 nacin4 years ago

  • Keywords i18n-change commit added

Looks good. Splitting up HTML elements like this can cause reversals when the printf var is moved around, as zeo pointed out.

comment:2 wpmuguru4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [15222]) arrange twentyten strings for easier translation, props zeo, fixes #13824

comment:3 rovo894 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Has class="meta-sep" been left inside of the translated string on purpose? Adding a patch to extract the class.

rovo894 years ago

Extract meta-sep class from translated string

comment:4 nacin4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

We generally try to leave HTML out of strings all together, but sometimes it can't be prevented without really hacking up a string.

In general, we don't typically sprintf out attributes quite like this. An exception would be the much longer class name of the other span. I don't see a problem leaving it as is -- it's no different than target="_blank" or other HTML that will slip in -- and I really don't want to break any more strings.

Closing as fixed.

Note: See TracTickets for help on using tickets.