WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#13825 closed defect (bug) (fixed)

Don't display an error when the theme supports widgets but not menus

Reported by: nacin Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Menus Keywords: has-patch ui-feedback
Focuses: Cc:

Description

Currently we display an annoying red bar when the theme doesn't support menus, but does support widgets.

Let's only have a bar (and make it yellow) before we've done anything. Once we have a menu, we can re-use the theme locations box to say "The current theme does not natively support menus, but you can use the "Custom Menu" widget to add any menus you create here to the theme's sidebar."

Note that this would not be a new string.

Attachments (1)

13825.diff (4.2 KB) - added by nacin 10 years ago.

Download all attachments as: .zip

Change History (4)

@nacin
10 years ago

#1 @nacin
10 years ago

I'm also now realizing that calling add_theme_support('nav-menus') and register_nav_menus() are two different things and if only the former is done (as was the original instance) we may have some peculiar results.

#2 @nacin
10 years ago

(In [15191]) Don't show an error when the theme supports widgets but not menus. see #13825.

#3 @nacin
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [15193]) Switch to current_theme_supports(menus) internally. Adding theme support for 'nav-menus' is deprecated in favor of register_nav_menu(s). fixes #13825.

Note: See TracTickets for help on using tickets.