Twenty Ten: Odd CSS rule messes with password protected form for galleries

[nacin]

Create a password protected post in the gallery category. On the home page, you'll get the form attempting to appear on the same line as the warning text due to:

.home #content .category-gallery .entry-content p {
    display: inline;
}

Screenshot attached. Originally reported by zeo.

Not sure what the CSS rule is for, but wontfix seems fine to me if it should stay.

The other outcome to this ticket I see as possible is it seems that post_class() deserves some post_password_required() love, in order to target this properly.

[zeo]

It's never a good idea to change p element to be inline. There are a couple more scenario to prove that. For example if a plugin or theme tries hook something to the_content or the_excerpt it will be inline along with the content summary.

There are 2 ways to fix this:

1) Delete the rule. see 13860.diff
2) Create a custom filter for the_content() and the_excerpt() to add "This gallery contains n photos." in-line with the original content.

[zeo]

The patch also change:

#content .gallery {
	margin: auto;
}

to:

#content .gallery {
	margin: 0 auto 18px;
}

where it will add margin bottom to gallery div with the same value as p. Currently there's no gap at the end of gallery div.

[zeo]

Add class post-password to post_class(). Also fix minor typo.

[iandstewart]

The Twenty Ten functions.php is already complicated enough. I think deleting the rule that keeps "This gallery contains n photos" inline with the excerpt is the way to go. This'll be in 1.0.2 in the directory (along with the bottom margin on galleries).

[iandstewart]

Needs dev-feedback for 13860-post-class-post-password.diff

[nacin]

Kicking this to 3.1 for the post_class patch, which looks good.

[westi]

(In [16138]) Add a post class if a password is required for the post to be displayed. See #13860 props zeo.

[markmcwilliams]

Looks fixed to me, but tell me off if it's not! ;)

[nacin]

Twenty Ten still needs to take advantage of the new class, I believe.

[obenland]

Bug was fixed with [15397].