WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#13861 closed enhancement (wontfix)

invalid password / user causes username and password boxes to bounce around

Reported by: mrmist Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.0
Component: UI Keywords:
Focuses: Cc:

Description

In Opera 9.51 or IE 8, if you log in with an invalid user/pass then, after the screen is redrawn with the red warning box the user/pass inputboxes bounce around from left to right on the screen a few times before settling in their correct position.

I'm not sure if this was intentionally introduced, but it doesn't look intentional, it looks broken, and odd.

Assigning to the UI component, there may be a better fit.

Change History (11)

comment:1 @duck_5 years ago

This is intentional, see [12815] and [12817] as well as a few recent fixes for iPhone and IE6.

I seem to remember it shaking the login_error div rather than the login form itself... hmm oh well :S

comment:2 @mrmist5 years ago

  • Type changed from defect (bug) to enhancement

Hmm ok.. I think it would make more sense if it did shake the error box,as at least then it would be shaking the thing that is explaining the problem, rather than the empty boxes (though I'm not sure why it has to shake anything). Currently it just appears broken, at least to me.

Switching to enhancement, then, on the assumption that the intention was to shake the input boxes.

comment:3 @ocean905 years ago

  • Milestone Unassigned deleted
  • Resolution set to worksforme
  • Status changed from new to closed

This is intentional and it was always the login form. Shaking the login_error div is not nice, it's hard to read the error message then. After the shaking the input box which has forced the error message/shaking will be focused. So closing as worksforme.

comment:4 @mrmist5 years ago

  • Keywords dev-feedback added
  • Milestone set to 3.1
  • Resolution worksforme deleted
  • Status changed from closed to reopened

I'd really rather prefer some more input on this. It looks poor IMO. It looks like a CSS error is causing the box to shake around, rather than an intentional act. I don't understand what the point of the shaking is, the red box was perfectly obvious enough, and the shaking actually distracts attention away from the error box.

comment:5 @ocean905 years ago

Too many lead devs have a Mac. ;-)
Why it looks like an CSS error? For me it's very smooth, see http://screenr.com/J7g

comment:6 follow-up: @dd325 years ago

I seem to remember it shaking the login_error div rather than the login form itself... hmm oh well :S

Nope, Its always shaked the login form, It shouldnt be shaking the login error div however at all..

This style of "shaking the head" is more common on macs apparently..

comment:7 in reply to: ↑ 6 @duck_5 years ago

Replying to dd32:

I seem to remember it shaking the login_error div rather than the login form itself... hmm oh well :S

Nope, Its always shaked the login form, It shouldnt be shaking the login error div however at all..

This style of "shaking the head" is more common on macs apparently..

Must've been my imagination moving the shake from the form to the error box.

comment:8 @wpmuguru5 years ago

  • Resolution set to wontfix
  • Status changed from reopened to closed

If you would like to disable the shake add this as a plugin:

function my_no_login_shake() {
	remove_action( 'login_head', 'wp_shake_js', 12 );
}
add_action('login_head','my_no_login_shake');

comment:9 follow-up: @mrmist5 years ago

  • Keywords dev-feedback removed
  • Milestone 3.1 deleted

Thanks Guru, I will put in that plugin.

I do sometimes wonder why unnecessary functionality like this goes in, and then has to be removed by adding even more code, but judging from this ticket the tide is against me on this one.

comment:10 @nacin5 years ago

This is honestly the first negative feedback I've seen on this. It's been in since early 3.0 and most people love it.

comment:11 in reply to: ↑ 9 @nacin5 years ago

Replying to mrmist:

Thanks Guru, I will put in that plugin.

I do sometimes wonder why unnecessary functionality like this goes in, and then has to be removed by adding even more code, but judging from this ticket the tide is against me on this one.

Personally, I would just avoid getting your password wrong. :-)

Note: See TracTickets for help on using tickets.