WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#13876 closed defect (bug) (fixed)

Favourite Actions for Editing a post shows 'Edit Post'

Reported by: dd32 Owned by: ryan
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: Posts, Post Types Keywords: has-patch needs-testing
Focuses: Cc:

Description

Under 2.9, when editing a post, The default Favourite Action would display "New Post". Under 3.0 it displays "Edit Post"

furthermore, 3.0 reads "Edit Post" when on the New Post screen, whereas 2.9 reads "Edit Posts"

I can track this town to $current_Screen being 'post' not 'edit-{$post_type}' as favorite_actions expects.

Attachments (2)

13876.diff (1.6 KB) - added by duck_ 8 years ago.
13876.2.diff (2.9 KB) - added by ryan 8 years ago.

Download all attachments as: .zip

Change History (9)

#1 @nacin
8 years ago

  • Keywords needs-patch added

#2 follow-up: @dd32
8 years ago

I attempted changing it in set_current_screen() only to find this set of code in post.php overriding it.. I'm just too lost in the screen code and what uses it right now to patch it.

@duck_
8 years ago

#3 @duck_
8 years ago

  • Keywords has-patch needs-testing added; needs-patch removed
  • Version set to 3.0

Didn't go for changing the $current_screen since quite a few things rely on it, so here's a potential fix with minimal changes.

#4 in reply to: ↑ 2 @nacin
8 years ago

Replying to dd32:

I'm just too lost in the screen code and what uses it right now to patch it.

Thinking ryan would be the best person to review all this.

#5 @nacin
8 years ago

  • Owner set to ryan
  • Status changed from new to assigned

@ryan
8 years ago

#6 @ryan
8 years ago

Patch adds an action field to the screen that is set to add for -new.php and -add.php screens. This is safer than changing the edit and add ids to be distinct.

#7 @ryan
8 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.